Move PackageSigningTests to async/await #7132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewHoos
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
AndrewHoos
requested review from
yim-lee
and removed request for
MaxDesiatov,
neonichu and
tomerd
|
@swift-ci test |
yim-lee
approved these changes
Nov 28, 2023
AndrewHoos
force-pushed
the
async-PackageSigningTests
branch
from
b4f14fa to
1375f1e
Compare
MaxDesiatov
approved these changes
Nov 28, 2023
Tests/PackageSigningTests/FilePackageSigningEntityStorageTests.swift
Outdated
Show resolved
Hide resolved
Tests/PackageSigningTests/FilePackageSigningEntityStorageTests.swift
Outdated
Show resolved
Hide resolved
Tests/PackageSigningTests/FilePackageSigningEntityStorageTests.swift
Outdated
Show resolved
Hide resolved
Tests/PackageSigningTests/FilePackageSigningEntityStorageTests.swift
Outdated
Show resolved
Hide resolved
…_await Add async alternatives to PackageSigningEntityStorage Mark non-async methods noasync Improve the fixture method to return the result of the body
AndrewHoos
force-pushed
the
async-PackageSigningTests
branch
from
1375f1e to
1b60a40
Compare
|
@swift-ci test |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt async/await in PackageSigningTests
Motivation:
Continue my efforts to replace temp_await with actual await
Modifications:
Add async alternatives to PackageSigningEntityStorage
Mark non-async methods noasync
Improve the fixture method to return the result of the body
Result:
No temp_await usage in PackageSigningTests