Move SwiftPackageCollectionsTool to async/await #7183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewHoos
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
MaxDesiatov
requested changes
Dec 11, 2023
Moves the CLI and CLI library to async/await Future commit: Move PackageCollectionsProtocol to async/await natively
AndrewHoos
force-pushed
the
async-collectionTool
branch
from
c1c9da2 to
7dd761d
Compare
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
reviewed
Dec 12, 2023
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
approved these changes
Dec 12, 2023
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the CLI and CLI library to async/await
Motivation:
Take another step to async/await in swift-package-manager without breaking API
Modifications:
Move SwiftPackageCollectionsTool associated code to async/await
Result:
No Dispatch or
temp_awaitusage inSwiftPackageCollectionsTool