Verify that the pinned version is still available #7242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings back the changes from #5898, but we only apply the change if we are actually resolving, not in the preflight resolution. This is kinda clunky, but I don't see a better way to do this without doing some more fundamental changes to the way to preflight resolution works. rdar://109487355 Co-authored-by: Dave Weston <[email protected]>
|
I would like to add a test for the scenarios the original change broke, but I am not sure how to do it. It doesn't seem like any of our test infrastructure is able to represent all the nuance here. |
|
@swift-ci please test |
MaxDesiatov
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the changes from #5898, but we only apply the change if we are actually resolving, not in the preflight resolution. This is kinda clunky, but I don't see a better way to do this without doing some more fundamental changes to the way to preflight resolution works.
rdar://109487355