Skip to content

Exercise bootstrapping with the XCBuild codepath in build-using-self #7253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 22, 2024

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Jan 15, 2024

This codepath could regress since we previously didn't run it in our PR testing.

With this change on macOS we always try to bootstrap SwiftPM with XCBuild on top of the usual llbuild build and test run.

It does increase the time spent on the macOS self-hosted job, but that job was already multiple times faster than our smoke test jobs, thus we have enough leeway to make it longer with the benefit of better PR testing.

This codepath could regress since we previously didn't run it in our PR testing.

With this change we always try to bootstrap SwiftPM with XCBuild on top of the usual llbuild build and test run.
@MaxDesiatov MaxDesiatov added test suite improvements to SwiftPM test suite build system Changes to interactions with build systems labels Jan 15, 2024
@MaxDesiatov MaxDesiatov self-assigned this Jan 15, 2024
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) January 15, 2024 10:04
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov marked this pull request as draft January 15, 2024 10:51
auto-merge was automatically disabled January 15, 2024 10:51

Pull request was converted to draft

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov marked this pull request as ready for review January 15, 2024 11:36
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) January 15, 2024 11:55
@MaxDesiatov MaxDesiatov requested a review from bnbarham January 17, 2024 12:58
@MaxDesiatov MaxDesiatov merged commit e5dbd8d into main Jan 22, 2024
@MaxDesiatov MaxDesiatov deleted the maxd/exercise-xcbuild-bootstrapping branch January 22, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Changes to interactions with build systems test suite improvements to SwiftPM test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants