-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Exercise bootstrapping with the XCBuild codepath in build-using-self
#7253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This codepath could regress since we previously didn't run it in our PR testing. With this change we always try to bootstrap SwiftPM with XCBuild on top of the usual llbuild build and test run.
@swift-ci test |
@swift-ci test |
@swift-ci test |
@swift-ci test |
auto-merge was automatically disabled
January 15, 2024 10:51
Pull request was converted to draft
@swift-ci test macos |
@swift-ci test macos |
@swift-ci test macos |
@swift-ci test macos |
@swift-ci test macos |
@swift-ci test macos |
@swift-ci test macos |
@swift-ci test |
@swift-ci test windows |
neonichu
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build system
Changes to interactions with build systems
test suite
improvements to SwiftPM test suite
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This codepath could regress since we previously didn't run it in our PR testing.
With this change on macOS we always try to bootstrap SwiftPM with XCBuild on top of the usual llbuild build and test run.
It does increase the time spent on the macOS self-hosted job, but that job was already multiple times faster than our smoke test jobs, thus we have enough leeway to make it longer with the benefit of better PR testing.