Move and refactor ProgressAnimation code from TSC
#7328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauhul
requested review from
bnbarham,
MaxDesiatov,
neonichu and
tomerd
as code owners
rauhul
force-pushed
the
rauhul/progress-bar-improvements
branch
from
da86a91 to
bd957be
Compare
SwiftPM uses ProgressAnimation from TSCUtilities in a variety of inconsistent manners across various swift-something commands. This commit replaces the uses of ProgressAnimation throughout SwiftPM with common entrypoints and lays the ground work for creating multi-line parallel progress animations as seen in tools like `bazel build` and `docker build`.
rauhul
force-pushed
the
rauhul/progress-bar-improvements
branch
from
bd957be to
cfa1bc1
Compare
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
reviewed
Feb 11, 2024
MaxDesiatov
reviewed
Feb 11, 2024
MaxDesiatov
reviewed
Feb 11, 2024
MaxDesiatov
reviewed
Feb 11, 2024
MaxDesiatov
reviewed
Feb 11, 2024
Sources/Basics/ProgressAnimation/SingleLinePercentProgressAnimation.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Feb 11, 2024
Sources/Basics/ProgressAnimation/PercentProgressAnimation.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Feb 11, 2024
MaxDesiatov
reviewed
Feb 11, 2024
MaxDesiatov
reviewed
Feb 11, 2024
|
@MaxDesiatov I pushed the requested changes as individual commits, please take a look when you have some time! |
MaxDesiatov
reviewed
Feb 12, 2024
MaxDesiatov
changed the title
ProgressAnimation code from TSC
MaxDesiatov
added
no functional change
|
@swift-ci test |
|
@swift-ci test linux |
|
@swift-ci test windows |
|
@swift-ci test linux |
1 similar comment
|
@swift-ci test linux |
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
SwiftPM uses ProgressAnimation from TSCUtilities in a variety of inconsistent manners across various swift-something commands. This commit replaces the uses of ProgressAnimation throughout SwiftPM with common entrypoints and lays the ground work for creating multi-line parallel progress animations as seen in tools like `bazel build` and `docker build`. --------- Co-authored-by: Max Desiatov <[email protected]>
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
SwiftPM uses ProgressAnimation from TSCUtilities in a variety of inconsistent manners across various swift-something commands. This commit replaces the uses of ProgressAnimation throughout SwiftPM with common entrypoints and lays the ground work for creating multi-line parallel progress animations as seen in tools like `bazel build` and `docker build`. --------- Co-authored-by: Max Desiatov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftPM uses ProgressAnimation from TSCUtilities in a variety of inconsistent manners across various swift-something commands. This commit replaces the uses of ProgressAnimation throughout SwiftPM with common entrypoints and lays the ground work for creating multi-line parallel progress animations as seen in tools like
bazel buildanddocker build.