Skip to content

Set correct minimum OS targets for new packages using swift-testing #7333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

grynspan
Copy link
Contributor

swift-testing has a minimum deployment target set higher than the default for packages. We need to ensure that it is respected by swift package init --enable-experimental-swift-testing.

@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan grynspan added swift test Changes impacting `swift test` tool swift package init Package templates command changes labels Feb 12, 2024
@MaxDesiatov MaxDesiatov changed the title Ensure new packages have the correct minimum OS targets when using swift-testing. Set correct minimum OS targets for new packages using swift-testing Feb 13, 2024
@MaxDesiatov MaxDesiatov added the needs tests This change needs test coverage label Feb 13, 2024
…ift-testing.

swift-testing has a minimum deployment target set higher than the default for packages. We need to ensure that it is respected by `swift package init --enable-experimental-swift-testing`.
@grynspan grynspan force-pushed the jgrynspan/minimum-targets-for-swift-testing branch from 45f7cd9 to d7e8613 Compare February 17, 2024 15:04
@grynspan
Copy link
Contributor Author

@swift-ci please test

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@grynspan grynspan merged commit 2fae93c into main Feb 18, 2024
@grynspan grynspan deleted the jgrynspan/minimum-targets-for-swift-testing branch February 18, 2024 13:10
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this pull request May 15, 2024
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tests This change needs test coverage swift package init Package templates command changes swift test Changes impacting `swift test` tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants