Fix .wasm product paths for wasm32-unknown-none triple
#7355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absence of this extension on produced binaries makes it inconvenient to work with triple, as you have to add that extension manually after the fact. For examples, HTTP servers frequently don't infer correct mime-type for these binaries, which confuses browsers that try to load these binaries.
MaxDesiatov
added
swift test
MaxDesiatov
commented
Feb 20, 2024
| @@ -3431,111 +3431,6 @@ final class BuildPlanTests: XCTestCase { | |||
| XCTAssertMatch(executablePathExtension, "exe") | |||
| } | |||
|
|
|||
| func testWASITarget() throws { | |||
There was a problem hiding this comment.
Moved to Tests/BuildTests/CrossCompilationBuildPlanTests.swift to make Tests/BuildTests/BuildPlanTests.swift smaller and increase parallelization during testing, as separate XCTestCase types can be parallelized, while multiple functions in XCTestCase can't.
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test windows |
kateinoigakukun
approved these changes
Feb 21, 2024
…xd/wasm-unknown-none-ext
|
@swift-ci test |
|
@swift-ci test windows |
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…#7355) Absence of this extension on produced binaries makes it inconvenient to work with triple, as you have to add that extension manually after the fact. For examples, HTTP servers frequently don't infer correct mime-type for these binaries, which confuses browsers that try to load these binaries.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…#7355) Absence of this extension on produced binaries makes it inconvenient to work with triple, as you have to add that extension manually after the fact. For examples, HTTP servers frequently don't infer correct mime-type for these binaries, which confuses browsers that try to load these binaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absence of this extension on produced binaries makes it inconvenient to work with triple, as you have to add that extension manually after the fact. For examples, HTTP servers frequently don't infer correct mime-type for these binaries, which confuses browsers that try to load these binaries.