Don't link libc++ or libstd++ for Embedded Swift #7357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These libraries are not usually available for embedded platforms. A workaround of passing this flag via `unsafeFlags` in `Package.swift` still remains after this change.
MaxDesiatov
added
bug
build system
|
@swift-ci test |
Comment on lines
59
to
60
| // Don't link unavailable libc++ or libstd++ when building for Embedded Swift | ||
| if !buildProduct.product.targets.contains(where: \.underlying.isEmbeddedSwiftTarget) { |
There was a problem hiding this comment.
I don't think C++ runtime library is unavailable for all Embedded platforms. For example, it seems like Pico SDK provides libc++: https://github.com/ARM-software/LLVM-embedded-toolchain-for-Arm
So it might be worth mentioning that in such case we ask users to explicitly specify desired C++ runtime via Xlinker.
There was a problem hiding this comment.
I've expanded the comment removing the word "unavailable", with potential solutions suggested there as well.
MaxDesiatov
commented
Feb 22, 2024
kateinoigakukun
approved these changes
Feb 22, 2024
|
@swift-ci test |
|
@swift-ci test windows |
6 similar comments
|
@swift-ci test windows |
|
@swift-ci test windows |
|
@swift-ci test windows |
|
@swift-ci test windows |
|
@swift-ci test windows |
|
@swift-ci test windows |
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
These libraries are not usually available for embedded platforms. A workaround of passing this flag via `unsafeFlags` in `Package.swift` still remains after this change.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
These libraries are not usually available for embedded platforms. A workaround of passing this flag via `unsafeFlags` in `Package.swift` still remains after this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These libraries are not usually available for embedded platforms. A workaround of passing this flag via
unsafeFlagsinPackage.swiftstill remains after this change.