Make ignore-lock a flag #7384
Merged
Make ignore-lock a flag #7384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to ignore package locking via `--ignore-lock` instead of `--ignore-lock true`.
rauhul
requested review from
bnbarham,
MaxDesiatov and
tomerd
as code owners
|
@swift-ci test |
MaxDesiatov
reviewed
Feb 29, 2024
|
With this change the old form is not allowed. I'm happy to also not make this change actually given that use of the option is highly limited |
Sadly yes/no;
|
MaxDesiatov
approved these changes
Feb 29, 2024
|
@swift-ci test |
|
@swift-ci test windows |
rauhul
added a commit
to apple/swift-mmio
that referenced
this pull request
Feb 29, 2024
SwiftPM 6 introduces a lock in the package build directory to avoid concurrent builds/tests. Unfortuntely this behavior is needed by the MMIOFileCheckTests currently. This commit adds a flag to avoid locking the package build directory when building with SwiftPM 6. Additionally, I have an inflight PR to change `--ignore-lock true` to `--ignore-lock` so this commit will require a follow-up fix, after that change in SwiftPM is merged (swiftlang/swift-package-manager#7384).
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
This allows users to ignore package locking via `--ignore-lock` instead of `--ignore-lock true`.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
This allows users to ignore package locking via `--ignore-lock` instead of `--ignore-lock true`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to ignore package locking via
--ignore-lockinstead of--ignore-lock true.