Pass all arguments when initing testing parameters in swift build
#7396
Conversation
grynspan
added
bug
swift test
grynspan
force-pushed
the
jgrynspan/7389-pass-all-test-params
branch
from
53d9941 to
e948488
Compare
|
@swift-ci please test |
grynspan
changed the title
swift build.swift build
|
Can you change the visibility of |
|
@rauhul We should take changes for |
gotcha, makes sense |
This is already marked as |
Oh! Excuse the noise then! |
It's not quite that simple. We only emit a warning when the entry point file doesn't exist (which makes sense, since if the flag was removed we would then start using the entry point file). If the entry point file is deprecated I think we need something new for that, or we should make the experimental entry point file flag not experimental and then remove the defaults (but we still need some migration path for that). |
|
I'm going to go ahead and merge this PR now to resolve the original issue, but let's continue this discussion in the forums or internally. |
…wiftlang#7396) Ensures that a fully-initialized `TestingParameters` structure is used with `swift build --build-tests` instead of using any default parameters (which will tend us toward the wrong output with packages that use `--enable-test-discovery` and still have LinuxMain.swift files.) Tested with swift-numerics on Ubuntu 22.04 aarch64; before the change, we'd hit the `fatalError()` call in that package's LinuxMain.swift file. After the change, we correctly run XCTest-based tests. Resolves swiftlang#7389.
…wiftlang#7396) Ensures that a fully-initialized `TestingParameters` structure is used with `swift build --build-tests` instead of using any default parameters (which will tend us toward the wrong output with packages that use `--enable-test-discovery` and still have LinuxMain.swift files.) Tested with swift-numerics on Ubuntu 22.04 aarch64; before the change, we'd hit the `fatalError()` call in that package's LinuxMain.swift file. After the change, we correctly run XCTest-based tests. Resolves swiftlang#7389.
Ensures that a fully-initialized
TestingParametersstructure is used withswift build --build-testsinstead of using any default parameters (which will tend us toward the wrong output with packages that use--enable-test-discoveryand still have LinuxMain.swift files.)Tested with swift-numerics on Ubuntu 22.04 aarch64; before the change, we'd hit the
fatalError()call in that package's LinuxMain.swift file. After the change, we correctly run XCTest-based tests.Resolves #7389.