Improvements to prebuilt library configuration handling #7433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
force-pushed
the
improvements-to-provided-libraries-handling
branch
from
fec2c13 to
16b4142
Compare
|
@swift-ci please test |
bnbarham
approved these changes
Mar 29, 2024
MaxDesiatov
added a commit
that referenced
this pull request
Jun 26, 2024
Cherry-pick of #7496 and #7433, excluding [16b4142](16b4142). **Explanation**: The idea is to enable provided libraries to be a part of a toolchain, which means that instead of completely eliding them from a package graph, they need to be handled post-resolution in a special way and reflected in a build plan for Swift targets (as compiler and linker arguments). Unified handling of `config.json` and `provided-libraries.json` resources and dropped use of `Bundle` type (config should always be a part of SDK or a toolchain). **Scope**: Localized, touches modules graph resolution and build planning only in certain configurations. **Risk**: Low. While the change has a somewhat broad scope, it's NFC for most builds and has been incubated on `main` for 2 months with no known issues. **Testing**: New test cases added and existing ones updated. **Issue**: rdar://125531670 **Reviewer**: @MaxDesiatov and @bnbarham --------- Co-authored-by: Pavel Yaskevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of minor improvements: