[6.0] Make supportedTriples optional in artifactbundle metadata
#7516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `supportedTriples` optional in artifactbundle metadata ### Motivation: We don't have a good way to express a Swift SDK that can be used on any host platform except for listing up all possible platforms. ### Modifications: This change allows `supportedTriples` field to be null or missing to express that the SDK is universally usable. Also this fixes a minor issue around `swift experimental-sdk configuration`, that did not take care of runtime compatibility of OS version in host triples. ### Result: SwiftPM now accepts host-platform independent Swift SDK
|
@swift-ci test |
MaxDesiatov
added
swift 6.0
bnbarham
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #7432.
Explanation: We don't have a good way to express a Swift SDK that can be used on any host platform except for listing up all possible platforms. This change allows
supportedTriplesfield to be null or missing to express that the SDK is universally usable. Also this fixes a minor issue aroundswift experimental-sdk configuration, that did not take care of runtime compatibility of OS version in host triples.Scope: Isolated to Swift SDKs.
Risk: Low due to limited scope. Incubated on the
mainbranch for 30 days with no known regressions.Testing: Automated. New test cases to
ArtifactsArchiveMetadataTests.swiftandSwiftSDKTests.swift.Issue: N/A
Reviewer: @MaxDesiatov on the original PR. @kateinoigakukun and @bnbarham on the cherry-pick PR.