[6.0.0][PackageModel] Toolchain: Split SwiftTesting flags between swift… #7908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compiler and linker (swiftlang#7907) - Explanation: Fixes a bug where keeping them together broke Symbol Graph Extract tool because it cannot handle `-Xlinker` flags. - Main Branch PR: swiftlang#7903 - Resolves: rdar://134406349 - Risk: Low (This is technically an NFC since it only re-arranging how to the flags are propagated but doesn't change them). - Reviewed By: @MaxDesiatov - Testing: New tests were added to the test suite. (cherry picked from commit 22b41d0)
|
@swift-ci please test |
bnbarham
approved these changes
Aug 23, 2024
|
Can we also just make symbol graph extract support all the driver/frontend args, it's pretty annoying that it only supports a subset. |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… compiler and linker
Fixes a bug where keeping them together broke Symbol Graph Extract tool because it cannot handle
-Xlinkerflags.Main Branch PR: [PackageModel] Toolchain: Split SwiftTesting flags between swift comp… #7903
6.0 Branch PR: [6.0][PackageModel] Toolchain: Split SwiftTesting flags between swift compiler and linker #7907
Resolves: rdar://134406349
Risk: Low (This is technically an NFC since it only re-arranging how to the flags are propagated but doesn't change them).
Reviewed By: @MaxDesiatov
Testing: New tests were added to the test suite.
(cherry picked from commit 22b41d0)