Minor internal API improvements #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods are not used anywhere and are potentially incorrect (indexInParent should probably be raw.numberOfChildren - 1). Remove the until we really need them
We are not actually advancing by a sibling but just by a node, simplify the method name to reflect this.
|
@swift-ci Please test |
akyrtzi
approved these changes
Jan 20, 2021
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Fix some tests that are broken against the latest toolchains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor internal API improvements:
advancedToEndOfChildrenThese methods are not used anywhere and are potentially incorrect (
indexInParentshould probably be initialized withraw.numberOfChildren - 1). Remove the until we really need themadvancedBySibling/reversedBySiblingtoadvancedBy/reversedByWe are not actually advancing by a sibling but just by a node, simplify the method name to reflect this.