[build] remove special placeholder libraries #21707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the unused parameter from the build (NFC).
Colocate the target specific library specification. Inline the single site use of the place holder ICU_UC and ICU_I18N libraries rather than trying to create special library processing code for that.
|
CC: @gottesmm @Rostepher |
|
@swift-ci please test |
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Apr 8, 2020
…ig, so that it doesn't break cross-compilation Passing swift_core_private_link_libraries to PRIVATE_LINK_LIBRARIES only works either when building a single host SDK alone or when needed by all SDKs, so move all that configuration to a swift_core_private_libraries() function that's called from add_swift_target_library() for each SDK/arch instead. Similarly, call a swift_runtime_static_libraries() function to split off libraries for the static stdlib with linux. Finally, remove the last uses of SWIFT_CONFIGURED_SDKS for anything more than checking, using SWIFT_SDKS instead, and move the static-stdlib linker file generation to the stdlib/ directory.
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Dec 11, 2021
…ig, so that it doesn't break cross-compilation Passing swift_core_private_link_libraries to PRIVATE_LINK_LIBRARIES only works either when building a single host SDK alone or when needed by all SDKs, so move all that configuration to a swift_core_private_libraries() function that's called from add_swift_target_library() for each SDK/arch instead. Also, generate a static-executable-args.lnk for each ELF SDK, rather than just for linux if it is the host SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.