[AutoDiff] [stdlib] Fix a bug in _jvpMultiply in SIMDDifferentiation.swift.gyb
#32963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dan-zheng |
|
@swift-ci Please smoke test |
dan-zheng
reviewed
Jul 17, 2020
| @@ -176,7 +176,7 @@ where | |||
| ) | |||
| { | |||
| return (lhs * rhs, { ltan, rtan in | |||
| return lhs * ltan + rtan * rhs | |||
| return lhs * rtan + ltan * rhs | |||
There was a problem hiding this comment.
Do differentiation tests need to be updated too? If not, could you please add a test checking this change?
There was a problem hiding this comment.
This wasn’t caught by the tests (it seems tests only contain multiplication by a scalar, which was correct). Will add a new test
There was a problem hiding this comment.
Fixed the multiplication test (the old one did not catch the bug because it had lhs == rhs and ltan == rtan).
rxwei
approved these changes
Jul 18, 2020
|
@swift-ci Please smoke test |
dan-zheng
reviewed
Jul 21, 2020
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recently merged PR (#32854) had a bug in it, fixing here.