[Sema] Diagnose type error on Clang type mismatch. #35305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varungandhi-apple
changed the title
varungandhi-apple
force-pushed
the
vg-diag-clang-type-mismatch
branch
from
ee750a4 to
cdfcde6
Compare
This comment has been minimized.
This comment has been minimized.
xedin
reviewed
Jan 8, 2021
varungandhi-apple
force-pushed
the
vg-diag-clang-type-mismatch
branch
from
cdfcde6 to
f992cdf
Compare
|
@swift-ci smoke test |
xedin
reviewed
Jan 8, 2021
varungandhi-apple
force-pushed
the
vg-diag-clang-type-mismatch
branch
from
f992cdf to
e205dfa
Compare
This comment has been minimized.
This comment has been minimized.
varungandhi-apple
force-pushed
the
vg-diag-clang-type-mismatch
branch
from
e205dfa to
cb00d19
Compare
|
Fixed an error where the boolean was not getting passed to certain SourceKit-related code. @swift-ci smoke test |
varungandhi-apple
force-pushed
the
vg-diag-clang-type-mismatch
branch
from
cb00d19 to
7d02d99
Compare
|
Removed an unnecessary change for doc printing based on feedback from Argyrios. This should fix a SourceKit test that was failing. @swift-ci smoke test |
This comment has been minimized.
This comment has been minimized.
xedin
reviewed
Jan 14, 2021
varungandhi-apple
force-pushed
the
vg-diag-clang-type-mismatch
branch
from
7d02d99 to
14936db
Compare
xedin
approved these changes
Jan 14, 2021
varungandhi-apple
force-pushed
the
vg-diag-clang-type-mismatch
branch
from
14936db to
1112930
Compare
This comment has been minimized.
This comment has been minimized.
varungandhi-apple
force-pushed
the
vg-diag-clang-type-mismatch
branch
from
1112930 to
21e9991
Compare
This comment has been minimized.
This comment has been minimized.
varungandhi-apple
force-pushed
the
vg-diag-clang-type-mismatch
branch
from
21e9991 to
74e74e5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
When -experimental-print-full-convention is set, we should be printing the full convention in diagnostics, doc comments etc.
Fixes rdar://71904525.
varungandhi-apple
force-pushed
the
vg-diag-clang-type-mismatch
branch
from
74e74e5 to
86b123a
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
Currently broken on macOS due to swift-syntax, waiting on swiftlang/swift-syntax#256 |
|
@swift-ci test source compatibility |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit has a crash test, third commit fixes the crash. I will investigate adding an implicit conversion later; for now, we just disallow any mismatch.
Fixes rdar://71904525.