[DebugInfo] Fix infinite recursion when opaque return type is defined inside function returning it #81794
Conversation
inside function returning it A stack overflow would happen when the compiler tried emitting debug info for a function whose opaque return type was declared inside the function itself. This fixes the issue by emitting a forward declaration for the function before emitting it. rdar://150313956
|
@swift-ci smoke test |
augusto2112
changed the title
| @@ -3201,6 +3204,11 @@ IRGenDebugInfoImpl::emitFunction(const SILDebugScope *DS, llvm::Function *Fn, | |||
| Name = getName(DS->Loc); | |||
| } | |||
|
|
|||
| llvm::DISubprogram *ReplaceableType = DBuilder.createTempFunctionFwdDecl( | |||
There was a problem hiding this comment.
nit: as someone unfamiliar with this API, parameter comments could help contextualize the various constants that are being passed through. although i see that isn't universally done in this file.
| @@ -3201,6 +3204,11 @@ IRGenDebugInfoImpl::emitFunction(const SILDebugScope *DS, llvm::Function *Fn, | |||
| Name = getName(DS->Loc); | |||
| } | |||
|
|
|||
| llvm::DISubprogram *ReplaceableType = DBuilder.createTempFunctionFwdDecl( | |||
| nullptr, Name, LinkageName, 0, 0, nullptr, 0); | |||
There was a problem hiding this comment.
Actually, if you passed in the correct scope here instead of nullptr — does that make the other change unnecessary?
There was a problem hiding this comment.
What do you mean? This is creating the temporary forward declaration so if we recurse back here we return it instead. If I passed the scope of the function when creating the temporary? What other change are you referring to?
There was a problem hiding this comment.
In line 976 you are guarding against a DIScope with a null DIFile. I was wondering if that is because your temporary Subprogram (which is a DIScope) has a null DIFile.
A stack overflow would happen when the compiler tried emitting debug info for a function whose opaque return type was declared inside the function itself. This fixes the issue by emitting a forward declaration for the function before emitting it.
rdar://150313956