Skip to content

[6.2] [Strict memory safety] Show issues with unsafe constructs in the for..in loop #81885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

[6.2] [Strict memory safety] Show issues with unsafe constructs in the for..in loop #81885

merged 1 commit into from
May 31, 2025

Conversation

DougGregor
Copy link
Member

  • Explanation: We weren't showing the unsafe uses when we determine that a for..in loop is unsafe. Do so, which generally means complaining about next() being unsafe.
  • Scope: Limited to one warning when strict memory safety is enabled.
  • Issues: rdar://151237127
  • Original PRs: [Strict memory safety] Show issues with unsafe constructs in the for..in loop #81884
  • Risk: Low. Improves the notes associated with a warning in strict memory safety mode.
  • Testing: CI

@DougGregor
[Strict memory safety] Show issues with unsafe constructs in the for.…
d08187a 
….in loop

We weren't showing the unsafe uses when we determine that a for..in
loop is unsafe. Do so, which generally means complaining about `next()`
being unsafe. Fixes rdar://151237127
@DougGregor DougGregor requested a review from a team as a code owner May 31, 2025 01:47
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor enabled auto-merge May 31, 2025 01:47
@DougGregor DougGregor merged commit e511c07 into swiftlang:release/6.2 May 31, 2025
5 checks passed
@DougGregor DougGregor deleted the unsafe-for-loop-uses-6.2 branch May 31, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @nkcsgexi