[6.2] MandatoryPerformanceOptimizations: make sure to handle de-serialized vtable methods #81974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
Jun 4, 2025
eeckstein
commented
- Explanation: This fixes a compiler crash in IRGen in Embedded Swift. This can happen when the MandatoryPerformanceOptimizations pass de-serializes a function from another module and this function allocates a class. Then the de-serialized vtable must be handled, too. Otherwise the vtable is not available in IRGen and IRGen crashes. This fixes a wasm build problem.
- Risk: Low. It's only affecting Embedded Swift.
- Testing: Tested by lit tests.
- Issue: rdar://152311945
- Reviewer: @MaxDesiatov
- Main branch PR: MandatoryPerformanceOptimizations: make sure to handle de-serialized vtable methods #81897
…vtable methods When de-serializing a function and this function allocates a class, the methods of the de-serialized vtable must be handled, too. Fixes an IRGen crash rdar://152311945
|
@swift-ci test |
MaxDesiatov
approved these changes
Jun 4, 2025
DougGregor
approved these changes
Jun 4, 2025
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.