LICM: fix a wrong tuple type when splitting loads #82012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
Jun 5, 2025
eeckstein
commented
- Explanation: This fixes a compiler crash cause by loop invariant code motion (LICM). When splitting load instructions, LICM created a tuple instruction without specifying the type. This caused a SIL type mismatch error in case original tuple type of the load has labels.
- Risk: Low. It's a very trivial change which only affects the SIL type of an instruction.
- Testing: Tested by a lit test.
- Issue: rdar://152588539
- Reviewer: @atrick
- Main branch PR: LICM: fix a wrong tuple type when splitting loads #81987
When creating a tuple, the type needs to be specified because otherwise, if the original tuple has labels, it will cause a type mismatch verification error. rdar://152588539
|
@swift-ci test |
tbkka
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.