Skip to content

Support recording multiple issues per test #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

plemarquand
Copy link
Contributor

Capture all the issues recorded in a failing test and add them as individual failures on the vscode.TestRun.

Capture all the issues recorded in a failing test and add them as
individual failures on the vscode.TestRun.
@plemarquand
Copy link
Contributor Author

@swift-server-bot test this please

1 similar comment
@adam-fowler
Copy link
Contributor

@swift-server-bot test this please

@adam-fowler
Copy link
Contributor

@swift-server-bot add to allowlist

Copy link
Contributor

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good
I've added a couple of questions
Plus it'd be good to add a test case, for two tests one after the other without any multiline error messages

- Add a test for two test failures in a row
- Update an outdated comment
@adam-fowler
Copy link
Contributor

@swift-server-bot test this please

@adam-fowler adam-fowler merged commit 098eef2 into swiftlang:main Apr 23, 2024
@plemarquand plemarquand deleted the record-multiple-test-issues branch April 23, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants