-
Notifications
You must be signed in to change notification settings - Fork 76
DevKit updates #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevKit updates #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for keeping the dev-kit up to date. i commented on a bunch of things that i changed directly on this repo that should be ported into dev-kit rather than be reverted here.
Btw: no problems to start with a single repository and then roll it out to the other ones, but we are tightly coupled to our testing component in dev. So we have to do them both hand in hand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! yeah lets drop old end-of-live symfony version.
i think we should up the minor version, as the strict types can reveal issues for users, and it will allow us to do a critical fix with symfony 2.8 support if really needed.
@dbu can you have a look at the tests, please? Do we expose an issue by using more strict code or did i break something through my changes? |
@dbu nothing to do, my fault. |
[ci skip] [skip ci]
79fd76e
to
8a471da
Compare
@dbu it took some time but now it is final and green. Any hints to add on changelog? any other issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job! i only have some change requests for the changelog, otherwise this looks excellent now!
Let's start it here also
ToDo: