This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Fix menu elements root #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
previously approved these changes
Dec 12, 2017
EmmanuelVella
force-pushed
the
elements-root
branch
from
2ef7762 to
d9770a8
Compare
|
Thank you David ! I just rebased my branch. |
ElectricMaxxx
pushed a commit
that referenced
this pull request
Jan 12, 2018
Improvements to run the tests use new testing version remove deprecated method DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates move files to new test app structure DevKit updates new test app structure fixes due to StyleCI fix phpcr-odm version make all admin services public make a block admin public too add admin bundles to own bundles.php DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates do not require non existing bundle set anymore remove fos jsrouting-bundle decleration
ElectricMaxxx
added a commit
that referenced
this pull request
Jan 23, 2018
…nts on way to SF4 compatiblility * Fix menu elements root (#127) Improvements to run the tests use new testing version remove deprecated method DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates move files to new test app structure DevKit updates new test app structure fixes due to StyleCI fix phpcr-odm version make all admin services public make a block admin public too add admin bundles to own bundles.php DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates DevKit updates do not require non existing bundle set anymore remove fos jsrouting-bundle decleration * remove use stmt. * use newer menu-bundle version * use a fork for symfony compat of the ckeditor bundle * fix composer.json * use own branch * avoid private service deprecation by using new compile pass in testing component * fix repository * use other repository url * revert ckeditor change * remove symfony dependency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
When editing a menu, the elements (children) root should be the menu path (for example
/cms/menu/top), not/cms/menu. Right ?