Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Conversation

torreytsui
Copy link

Q A
Branch? use_fos_ckeditor (#135)
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets Help unblocking 129
License MIT

Objective

When a new cvs github repo is introduced as dependency (#135), composer on travis needs to be able to read it - this in turns require a public read privilege token.

This PR offer a way to set it up

Usage

A travis env var is introduced, allowing setting up GITHUB_TOKEN on travis with a github token.

@torreytsui
Copy link
Author

@ElectricMaxxx Could you please set up a env var GITHUB_TOKEN on Travis so that the test will turn green?

Make sure the token has only got public repo read privilege though.

@torreytsui torreytsui force-pushed the use_fos_ckeditor_with_github_token_travis branch 2 times, most recently from 7b217a1 to ae1032c Compare August 10, 2018 09:42
    So as to workaround this issue:

    [1803.3MB/30.33s] Looking at all rules.
    [1803.7MB/32.78s] [1803.8MB/34.62s] Something's changed, looking at all rules again (pass [1803.9MB/36.24s] Something's change[1804.0MB/37.85s] Something's change[1804.1MB/39.62s] Something's change[1804.1MB/41.38s] Something's change[1804.2MB/42.99s] Something's change[1804.3MB/44.62s] Something's change[1804.4MB/46.24s] Something's change[1804.5MB/47.92s] Something's change[1804.6MB/49.69s] Something's change[1804.7MB/51.42s] Something's change[1804.7MB/53.20s] Something's change[1804.8MB/54.85s] Something's change[1804.9MB/56.57s] Something's change[1805.0MB/58.22s] Something's change[1805.1MB/59.83s] Something's change[1805.2MB/62.32s] Something's change[1805.3MB/64.74s] Something's change[1805.3MB/66.65s] Something's change[1805.4MB/68.62s] Something's change[1805.5MB/70.46s] Something's change[1805.6MB/72.27s] Something's change[1805.7MB/74.92s] Something's change[1805.8MB/77.31s] Something's change[1805.8MB/79.74s] Something's change[1805.9MB/81.62s] Something's change[1806.0MB/83.27s] Something's change[1806.1MB/84.89s] Something's change[1806.2MB/86.56s] Something's change[1806.3MB/88.26s] Something's change[1806.3MB/89.98s] Something's change[1806.4MB/91.80s] Something's change[1806.5MB/93.86s] Something's change[1806.6MB/95.61s] Something's change[1806.7MB/97.29s] Something's change[1806.8MB/98.98s] Something's changed[1806.9MB/100.54s] Something's changed[1807.0MB/102.17s] Something's changed[1807.0MB/103.85s] Something's changed[1807.1MB/105.39s] Something's changed[1807.2MB/107.19s] Something's changed[1807.3MB/108.74s] Something's changed[1807.4MB/110.25s] Something's changed[1807.4MB/111.87s] Something's changed[1807.5MB/113.41s] Something's changed[1807.6MB/114.97s] Something's changed[1807.7MB/116.55s] Something's changed[1807.7MB/118.10s] Something's changed[1807.8MB/119.68s] Something's changed[1807.9MB/121.52s] Something's changed[1807.9MB/123.31s] Something's changed[1808.0MB/125.24s] Something's changed[1808.1MB/127.06s] Something's changed[1808.2MB/129.15s] Something's changed[1808.2MB/131.08s] Something's changed[1808.3MB/132.96s] Something's changed[1808.4MB/134.68s] Something's changed[1808.5MB/137.08s] Something's changed[1808.5MB/138.87s] Something's changed[1808.6MB/140.93s] Something's changed[1808.7MB/142.68s] Something's changed[1808.8MB/144.36s] Something's changed[1808.7MB/147.64s] Something's changed[1809.1MB/151.19s] Something's changed[1809.1MB/153.04s] Something's changed[1809.2MB/155.03s] Something's changed[1809.2MB/156.93s] Something's changed[1809.3MB/158.97s] Something's changed[1809.3MB/161.97s] Something's changed[1809.4MB/164.36s] Something's changed[1809.5MB/166.34s] Something's changed[1809.6MB/169.33s] Something's changed[1809.6MB/171.15s] Something's changed[1809.7MB/174.53s] Something's changed[1809.8MB/177.61s] Something's changed[1809.8MB/182.94s] Something's changed[1809.9MB/185.59s] Something's changed[1810.0MB/187.39s] Something's changed[1810.0MB/189.16s] Something's changed[1810.1MB/191.54s] Something's changed[1810.2MB/194.12s] Something's changed[1810.4MB/196.27s] Something's changed[1810.5MB/198.69s] Something's changed[1810.6MB/200.96s] Something's changed[1810.7MB/203.53s] Something's changed[1810.8MB/205.77s] Something's changed[1811.0MB/208.21s] Something's changed[1811.1MB/210.62s] Something's changed[1811.2MB/213.05s] Something's changed[1811.3MB/215.22s] Something's changed[1811.4MB/217.65s] Something's changed[1811.5MB/219.37s] Something's changed[1811.7MB/222.18s] Something's changed[1811.9MB/224.54s] Something's changed[1812.0MB/226.52s] Something's changed[1812.1MB/228.64s] Something's changed[1812.3MB/230.06s] Something's changed[1812.4MB/232.31s] Something's changed[1812.5MB/233.80s] Something's changed[1812.8MB/235.74s] Something's changed[1813.0MB/237.79s] Something's changed[1814.4MB/239.69s] Something's changed[1814.4MB/241.57s] Something's changed[1815.4MB/244.29s] Something's changed[1815.6MB/246.05s] Something's changed[1815.0MB/247.64s] Something's changed[1815.9MB/249.36s] Something's changed[1815.6MB/251.03s] Something's changed[1815.1MB/252.57s] Something's changed[1815.9MB/254.28s] Something's changed[1815.7MB/256.27s] Something's changed[1815.1MB/258.08s] Something's changed[1816.0MB/259.63s] Something's changed[1815.7MB/261.19s] Something's changed[1815.1MB/262.62s] Something's changed[1816.0MB/264.14s] Something's changed[1815.7MB/265.97s] Something's change[1815.2MB/268.18s] Something's changed[1816.0MB/270.62s] Something's changed[1815.8MB/273.69s] Something's changed[1815.2MB/276.37s] Something's changed[1816.1MB/278.07s] Something's changed[1815.8MB/280.72s] Something's changed[1815.3MB/282.86s] Something's changed[1816.1MB/284.42s] Something's changed[1815.9MB/286.00s] Something's changed[1815.3MB/287.68s] Something's changed[1816.2MB/289.27s] Something's changed[1815.9MB/291.19s] Something's changed[1815.3MB/293.51s] Something's changed[1816.2MB/295.98s] Something's changed[1815.9MB/297.73s] Something's changed[1815.4MB/301.00s] Something's changed[1816.2MB/304.83s] Something's changed[1816.0MB/306.54s] Something's changed[1815.4MB/308.09s] Something's changed[1816.3MB/309.77s] Something's changed[1816.0MB/311.25s] Something's changed[1815.4MB/312.76s] Something's changed[1816.3MB/314.37s] Something's changed[1816.1MB/316.05s] Something's changed, looking at all rules again (pass #142)^CCommand terminated abnormally.
@torreytsui torreytsui force-pushed the use_fos_ckeditor_with_github_token_travis branch from ae1032c to d390781 Compare August 10, 2018 09:45
@torreytsui
Copy link
Author

Test passed and seem only some deprecations (~300) left to update

@ElectricMaxxx ElectricMaxxx self-requested a review August 11, 2018 01:16
@ElectricMaxxx
Copy link
Member

@torreytsui
Copy link
Author

Oh, I see. The dependency is for temporary use only. I will close this PR

@torreytsui torreytsui closed this Aug 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants