This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Use peerDependencies instead of dependencies for react-native #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be great. Currently holding off on using the Router because of this issue. |
|
please merge this.. |
|
A pull request with this change already was proposed |
|
Forgot about this and decided to close since #42 exists. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@t4t5, I am loving the react-native-router. Had some problems today with react-native 0.6.0 and took a stab at correcting them. Not sure if this is how you want to go with it but would rather send a PR than just report a problem.
Used approach from here: alinz/react-native-navbar@0d4715e
Thanks,
Eric