Skip to content

Added new feature to force empty values to nil #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ fluent plugin mysql bulk insert is high performance and on duplicate key update

## Note
fluent-plugin-mysql-bulk merged this repository.

This repository now includes the mysql_bulk plugin.
[mysql plugin](README_mysql.md) is deprecated. You should use mysql_bulk.

v0.1.5 only supports fluentd-0.12.X and v0.2.0 only supports fluentd-0.14.X.
Expand Down Expand Up @@ -33,6 +33,7 @@ table|bulk insert table (require)
on_duplicate_key_update|on duplicate key update enable (true:false)
on_duplicate_update_keys|on duplicate key update column, comma separator
transaction_isolation_level|set transaction isolation level(default: nil)
column_names_empty_to_null|Columns for which empty values should be converted to nil (null in SQL)

## Configuration Example(bulk insert)

Expand Down
10 changes: 10 additions & 0 deletions lib/fluent/plugin/out_mysql_bulk.rb
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ class MysqlBulkOutput < Output
config_param :transaction_isolation_level, :enum, list: [:read_uncommitted, :read_committed, :repeatable_read, :serializable], default: nil,
desc: "Set transaction isolation level."

config_param :column_names_empty_to_null, :string, default: nil,
desc: "Columns for which empty values are stored as NULL (no quotes)"

attr_accessor :handler

def initialize
Expand Down Expand Up @@ -100,6 +103,7 @@ def configure(conf)

@column_names = @column_names.split(',').collect(&:strip)
@key_names = @key_names.nil? ? @column_names : @key_names.split(',').collect(&:strip)
@column_names_empty_to_null = @column_names_empty_to_null.split(',').collect(&:strip) if @column_names_empty_to_null
@json_key_names = @json_key_names.split(',') if @json_key_names
@unixtimestamp_key_names = @unixtimestamp_key_names.split(',') if @unixtimestamp_key_names
end
Expand Down Expand Up @@ -200,6 +204,12 @@ def format_proc
if @unixtimestamp_key_names && @unixtimestamp_key_names.include?(key)
value = Time.at(value).strftime('%Y-%m-%d %H:%M:%S')
end

if @column_names_empty_to_null && @column_names_empty_to_null.include?(key)
if value.nil? || value.empty?
value = nil
end
end
end
values << value
end
Expand Down