-
Notifications
You must be signed in to change notification settings - Fork 15
Fix pagination + multipart indexes #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mRrvz Alexey, thanks for the patch!
Few comments:
- could you add explanations to commit messages "Fix unnecessary sharding key", "Remove unnecessary test". For me it is not clear what was fixed regarding to sharding key and why we need to remove test.
- I suppose the item to changelog should be added in the same commit where fix was added.
…o GE iterator when we passing after_tuple param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patch. Please resolve the rest of not my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make Changelog more informative.
30aa400
to
ab46af8
Compare
ab46af8
to
4d0f002
Compare
Fixed invalid results for pagination queries when filtering on
a parts of a composite index. Now, instead of "scrolling"
to the desired tuple (during pagination) using the
scroll_to_after_tuple
function, we change the iterators(
EQ
->GE
,REQ
->LT
) to use them inindex:pairs
function, together with a combination withadditional filtration. Closes #170