roles: fix bugs after config reload #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DifferentialOrange
approved these changes
Jun 25, 2025
DerekBum
approved these changes
Jun 26, 2025
There was a but if the server is not used (for example, it was removed from the configuration), it will still be running after the configuration is reloaded. This patch fixes it. Closes #212
If the `listen` value was changed the server won't update it after config reload. After the patch this bug was fixed. Closes #209
themilchenko
force-pushed
the
themilchenko/gh-209-fix-server-address-change
branch
from
94dce46 to
ef87d4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch-set fixes a several bugs related with config update.
Closes #209
Closes #212