cluster: drop instances removed from config in cluster.sync #424
Conversation
Currently, cluster:sync() leaves instances removed from the config in the instance list. This makes cluster:reload() fail because it tries to reload the config for all instances including those that are not in the config anymore. To fix that, let's make cluster:sync() drop instances that were removed from the config. Closes tarantool#423
| for _, iserver in pairs(old_server_map) do | ||
| iserver:drop() | ||
| end |
There was a problem hiding this comment.
That's interesting. We don't start new instances in :sync(), just create server objects in Lua. So, it looks like we shouldn't stop them too.
But,
- If we don't stop the server, it remains running after the test case.
- A user may want some automation about synchronization of the configured and present instances.
The first point is simple: just track the excluded server objects in some list to call :drop() on it in the after_each hook. self._excluded_server_map or something like this. We can also reuse the server object from this mapping if a previously deleted server is added again.
The second point is really interesting. Since tarantool 3.3 a user can configure autoexpelling if needed. So, we really need just update the config and start/stop processes to manage the cluster.
It looks like we really have two suitable methods:
- update config + update server objects
- update config + update server objects + start/stop processes
The first one is what :sync() do now. We can implement the second as a :sync() option. What do you think?
Currently,
cluster:sync()leaves instances removed from the config in the instance list. This makescluster:reload()fail because it tries to reload the config for all instances including those that are not in the config anymore. To fix that, let's makecluster:sync()drop instances that were removed from the config.Closes #423