[Release] v0.4.1 - Integration / Beta Branch #85

fbartho · 2020-10-28T20:14:19Z

-- Change PRs are enumerated in the tracking milestone

Changes

Feature: Ability to register the PushNotification token with Zendesk Fix email field on setVisitorInfo method #77
Feature: Ability to register the Zendesk AppId (not required for all users) Allow JS init with param app Id #72
Android: Fix visitorInfo - email Typo Fix email field on setVisitorInfo method #77
Android: Fix visitorInfo + PreChatForm Upstream API Behavior Differences Fix android visitor info #82 Android Visitor Info Additions #84
Potentially Breaking: adds a minimum version of 2.9.0 for ZendeskChatSDK

kittichanr · 2020-11-08T01:31:30Z

I have tried push notification this version. it's work in android but ios not working. How can I fix it ?

please help.

gabrielperales · 2020-11-20T11:20:30Z

@petchkubb can you try to add this to your AppDelegate.m:

#import <RNCPushNotificationIOS.h>
#import <ChatProvidersSDK/ChatProvidersSDK.h>


- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
{
  [ZDKChat registerPushToken:deviceToken];
  [RNCPushNotificationIOS didRegisterForRemoteNotificationsWithDeviceToken:deviceToken];
}

Regards

gabrielperales · 2020-11-20T11:54:31Z

@fbartho I think @petchkubb is right, if I don't add the code I posted before I'm not getting the push notifications. Maybe the token conversion from NSString to NSData is wrong?

RCT_EXPORT_METHOD(registerPushToken:(NSString *)token) {
	dispatch_sync(dispatch_get_main_queue(), ^{
		[ZDKChat registerPushToken:[RCTConvert NSData:token]];
	});
}

fbartho · 2020-11-20T19:45:30Z

@gabrielperales / @petchkubb -- Have you added log messages to prove you called the registerPushToken API from the JS side of things?

I'm happy to try other ways of converting an NSString to an NSData. [NSData dataWithString: token] comes to mind. Have you tested that one?

gabrielperales · 2020-11-23T12:46:33Z

@fbartho No, I haven't. I don't know too much about Objective-C... so when I made it work with the snipped I posted above... I stopped searching for other ways to make it work.

gabrielperales · 2020-11-23T14:04:05Z

android/src/main/java/com/taskrabbit/zendesk/RNZendeskChatModule.java

@@ -282,10 +342,38 @@ public void startChat(ReadableMap options) {

    @ReactMethod
    public void registerPushToken(String token) {
-        PushNotificationsProvider pushProvider = Chat.INSTANCE.providers().pushNotificationProvider();
+        PushNotificationsProvider pushProvider = Chat.INSTANCE.providers().pushNotificationsProvider();


is this update right? I got the code from the docs and is says that the method is pushNotificationProvider() without the s.

PushNotificationsProvider pushProvider = Chat.INSTANCE.providers().pushNotificationProvider(); if (pushProvider != null) { pushProvider.registerPushToken("YOUR FIREBASE TOKEN"); }

Ok, I just checked it and it's alright.

it's works thank you @gabrielperales

I'm glad you make it work @petchkubb 👍 . It was working for you in android? I'm not able to receive push notifications from the chat in my android App. Did you configure something I could be missing or something?

gabrielperales · 2020-11-23T16:34:04Z

@gabrielperales / @petchkubb -- Have you added log messages to prove you called the registerPushToken API from the JS side of things?

I'm happy to try other ways of converting an NSString to an NSData. [NSData dataWithString: token] comes to mind. Have you tested that one?

I'm checking that there is another method called registerPushTokenString which receives the string so we shouldn't have to convert it. I'm going to try with that.

gabrielperales · 2020-11-23T18:33:19Z

@fbartho I changed registerPushToken for registerPushTokenString and I can confirm that it works :)

breadadams · 2020-11-25T23:25:12Z

@petchkubb did you have to follow any extra steps to get things working on Android?

This fix the following compilation error I have on the release/0.4.1 branch: /Users/my-user/work/my-app/node_modules/react-native-zendesk-chat/android/src/main/java/com/taskrabbit/zendesk/RNZendeskChatModule.java:146: error: cannot find symbol & ApplicationInfo.FLAG_DEBUGGABLE) == 0)) { ^ symbol: variable ApplicationInfo location: class RNZendeskChatModule

fix: added import to fix compilation error

…l appId

Use same init wrapper on iOS as Android to handle optional param

switched registerPushToken by registerPushTokenString on ios

Added Obtaining the YOUR_ZENDESK_ACCOUNT_KEY section to readme

Necessary for calling [ZDKChat registerPushTokenWithString: ...]

fbartho · 2021-01-21T02:19:26Z

v0.4.1-beta.7 is ready for anybody watching this PR!

Fix typo and missing import

Feature/agents online

Pierre-Alexandre Dupuy and others added 3 commits October 20, 2020 08:57

Fix android visitor info and bump android dependencies

7788cb7

Minimize Android Module-scoped globals

2523b71

Merge branch 'fb/android-visitor-info-additions' into release/v0.4.1

2586281

fbartho added this to the v0.4.1 Bug Fixes + Optional Features milestone Oct 28, 2020

fbartho and others added 13 commits October 28, 2020 14:10

New react-native peerDependency Line

33521ad

v0.4.1-beta.0

0f0b67e

Android: PushNotifications Typo/Import Fix

c633dbf

v0.4.1-beta.1

44003f2

Fix React-Native Android Zendesk AppId init implementation

6906a29

v0.4.1-beta.2

86501eb

Android: Fix up (Java) String Equality testing

c32d9dd

Merge branch 'fb/android-visitor-info-additions' into release/v0.4.1

4a873a1

v0.4.1-beta.3

5c47790

v0.4.1-beta.4

eddd93d

Suppress debug logs for release / non-debuggable Builds

91d08af

updated readme to have Optaining the section

7cde266

fix spelling

e542b55

gabrielperales reviewed Nov 23, 2020

View reviewed changes

switched registerPushToken by registerPushTokenString on ios

42296c2

acarpe and others added 3 commits December 3, 2020 09:58

Merge pull request #92 from acarpe/patch-1

629979e

fix: added import to fix compilation error

use same wrapper on iOS as Android so init can be called with optiona…

41e4429

…l appId

fbartho and others added 8 commits December 4, 2020 22:19

Merge pull request #93 from emkman/release/v0.4.1

42d5eb1

Use same init wrapper on iOS as Android to handle optional param

Merge pull request #91 from wombak/release/v0.4.1

6a68a16

switched registerPushToken by registerPushTokenString on ios

Merge pull request #86 from arelstone/main

9d55a30

Added Obtaining the YOUR_ZENDESK_ACCOUNT_KEY section to readme

v0.4.1-beta.5

7413eb4

Add a minimum SDK dependency

0d32427

Necessary for calling [ZDKChat registerPushTokenWithString: ...]

v0.4.1-beta.6

cec1633

Simplify the dependency constraint b/c cocoapods

13ef3bd

v0.4.1-beta.7

12d0b01

gabrielperales and others added 11 commits March 30, 2021 18:12

added method to check if there are agents online

a23770d

fixed typo on getAccount

1409b17

Fix typo and missing import

1f05299

Merge pull request #111 from uphold-forks/bugfix/missing-import-android

3fd00eb

Fix typo and missing import

Merge pull request #110 from wombak/feature/agentsOnline

6e4c7dd

Feature/agents online

Prettier Fix

6e156b0

v0.4.1-beta.8

f207ec8

Reject if no account is found (don't leave promises unterminated)

6e531db

Contributor Update

34887c6

Android syntax/import fixes

f5b1177

v0.4.1-beta.9

b36cb9e

fbartho mentioned this pull request May 5, 2021

Feature/agents online #110

Merged

v0.4.1

4291954

fbartho merged commit 87c1148 into main May 5, 2021

fbartho deleted the release/v0.4.1 branch May 5, 2021 17:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Release] v0.4.1 - Integration / Beta Branch #85

[Release] v0.4.1 - Integration / Beta Branch #85

Uh oh!

fbartho commented Oct 28, 2020 •

edited

Loading

Uh oh!

kittichanr commented Nov 8, 2020

Uh oh!

gabrielperales commented Nov 20, 2020

Uh oh!

gabrielperales commented Nov 20, 2020 •

edited

Loading

Uh oh!

fbartho commented Nov 20, 2020

Uh oh!

gabrielperales commented Nov 23, 2020

Uh oh!

gabrielperales Nov 23, 2020

Uh oh!

gabrielperales Nov 23, 2020 •

edited

Loading

Uh oh!

kittichanr Nov 23, 2020

Uh oh!

gabrielperales Nov 23, 2020

Uh oh!

gabrielperales commented Nov 23, 2020

Uh oh!

gabrielperales commented Nov 23, 2020

Uh oh!

breadadams commented Nov 25, 2020

Uh oh!

fbartho commented Jan 21, 2021

Uh oh!

Uh oh!

[Release] v0.4.1 - Integration / Beta Branch #85

[Release] v0.4.1 - Integration / Beta Branch #85

Uh oh!

Conversation

fbartho commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kittichanr commented Nov 8, 2020

Uh oh!

gabrielperales commented Nov 20, 2020

Uh oh!

gabrielperales commented Nov 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fbartho commented Nov 20, 2020

Uh oh!

gabrielperales commented Nov 23, 2020

Uh oh!

gabrielperales Nov 23, 2020

Choose a reason for hiding this comment

Uh oh!

gabrielperales Nov 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kittichanr Nov 23, 2020

Choose a reason for hiding this comment

Uh oh!

gabrielperales Nov 23, 2020

Choose a reason for hiding this comment

Uh oh!

gabrielperales commented Nov 23, 2020

Uh oh!

gabrielperales commented Nov 23, 2020

Uh oh!

breadadams commented Nov 25, 2020

Uh oh!

fbartho commented Jan 21, 2021

Uh oh!

Uh oh!

fbartho commented Oct 28, 2020 •

edited

Loading

gabrielperales commented Nov 20, 2020 •

edited

Loading

gabrielperales Nov 23, 2020 •

edited

Loading