Skip to content

Normative: add Float16Array and Math.f16round #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

Normative: add Float16Array and Math.f16round #3532

merged 1 commit into from
Feb 27, 2025

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Feb 6, 2025

This adds the spec text from proposal-float16array. I intend to ask for stage 4 at the upcoming meeting.

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. has test262 tests labels Feb 6, 2025
@bakkot bakkot mentioned this pull request Feb 6, 2025
Closed
10 tasks
syg
syg approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jmdyck
jmdyck reviewed Feb 11, 2025
View reviewed changes
michaelficarra
michaelficarra reviewed Feb 14, 2025
View reviewed changes
michaelficarra
michaelficarra reviewed Feb 14, 2025
View reviewed changes
michaelficarra
michaelficarra reviewed Feb 14, 2025
View reviewed changes
michaelficarra
michaelficarra approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@bakkot bakkot added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Feb 18, 2025
@bakkot bakkot added editor call to be discussed in the next editor call ready to merge Editors believe this PR needs no further reviews, and is ready to land. labels Feb 26, 2025
@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Feb 26, 2025
@ljharb ljharb merged commit d430ace into main Feb 27, 2025
8 checks passed
@ljharb ljharb deleted the float16array branch February 27, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syg syg syg approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@jmdyck jmdyck jmdyck left review comments

Assignees
No one assigned
Labels
has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bakkot @syg @michaelficarra @jmdyck @ljharb