[Feature Request] Investigate asyncio.as_completed and asyncio.wait usage of `set` as non-deterministic #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

cretz opened this issue May 6, 2024 · 1 comment · Fixed by #533

Labels

Member

cretz commented May 6, 2024 •

edited

Loading

Describe the solution you'd like

asyncio.as_completed and asyncio.wait may be non-deterministic in their use of set. See https://github.com/python/cpython/blob/v3.12.3/Lib/asyncio/tasks.py#L609 and https://github.com/python/cpython/blob/v3.12.3/Lib/asyncio/tasks.py#L458. See if anything can be done and if not, document that they are dangerous and warn on their use. May need to provide deterministic alternatives.

The text was updated successfully, but these errors were encountered:

cretz added the enhancement label

Member Author

cretz commented May 6, 2024

See also #429

cretz added a commit to cretz/temporal-sdk-python that referenced this issue


          Add deterministic alternatives for asyncio.wait and asyncio.as_completed

87e80e4

Fixes temporalio#429
Fixes temporalio#518

cretz mentioned this issue

Add deterministic alternatives for asyncio.wait and asyncio.as_completed #533

Merged

cretz added a commit to cretz/temporal-sdk-python that referenced this issue


          Add deterministic alternatives for asyncio.wait and asyncio.as_completed

2bc0718

Fixes temporalio#429
Fixes temporalio#518

cretz closed this as completed in #533

cretz closed this as completed in

365cead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment