Skip to content

[Bug] Make sure is_replaying is True upon eviction, and only throw certain exception types out on eviction #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cretz opened this issue May 9, 2024 · 2 comments · Fixed by #524
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented May 9, 2024

Describe the bug

Today, anyone in a finally or except Exception can catch exceptions occurring during eviction and do side-effecting things like logging. We need to set is_replaying to True during eviction (or maybe Core does) and we need to make a new class WorkflowEvictingException(BaseException) that we use when we see stuff happening during delete.

@cretz cretz added the bug Something isn't working label May 9, 2024
cretz added a commit to cretz/temporal-sdk-python that referenced this issue May 9, 2024
@jpcarlino
Copy link

@cretz I recently upgraded our pipeline workers to use the Temporal SDK 1.6.0. Since then I see this error being printed in our logs: Ignoring add while deleting, which seems to come from this line. I see you did change it to this.

My question is: should I catch that exception and ignore it? If not, what should I do on my side to avoid that. Unfortunately it is flooding our logs right now. Thank you.

@cretz
Copy link
Member Author

cretz commented May 23, 2024

Yes, this issue is meant to fix that problem because logging should not occur during is_replaying. In the meantime you can ignore these exceptions, they are only on cache eviction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants