Skip to content

Create CODEOWNERS #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2023
Merged

Create CODEOWNERS #323

merged 3 commits into from
May 31, 2023

Conversation

jackdawm
Copy link
Contributor

What was changed

Add CODEOWNERS so that Security can own the Semgrep rules files and paths.

Why?

We are adding Semgrep for static analysis to this repository, and only the security team should be able to approve exclusions from the policy.

Checklist

How was this tested:
We ran this scanner on internal repos with this CODEOWNERS file and it worked as expected.

Add CODEOWNERS so that Security can own the Semgrep rules files and paths.
@CLAassistant
Copy link

CLAassistant commented May 30, 2023

CLA assistant check
All committers have signed the CLA.

@jackdawm jackdawm requested a review from cretz May 30, 2023 20:35
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Minor comments. Also you may have to click approve on the CLA button.

CODEOWNERS Outdated
Copy link
Member

@cretz cretz May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this under .github dir? No need for top-level user view.

Co-authored-by: Chad Retz <[email protected]>
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just the one more request to move under .github/ and we're good to go!

Per Chad's comment, moving out of top level dir
@cretz cretz merged commit b0daaa3 into main May 31, 2023
@cretz cretz deleted the codeowners branch May 31, 2023 15:17
@cretz
Copy link
Member

cretz commented May 31, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants