Skip to content

Ensure update input and responses are run through converters #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2024
Merged

Ensure update input and responses are run through converters #478

merged 1 commit into from
Feb 23, 2024

Conversation

Sushisource
Copy link
Member

What was changed

Make updates get run through data converters

Why?

Kind of important. Maybe people want to encrypt stuff.

Checklist

  1. Closes [Bug] Updates not run through data converters #477

  2. How was this tested:
    Added updates to custom encoder test

  3. Any docs updates needed?

@Sushisource Sushisource requested a review from a team as a code owner February 22, 2024 23:20
bergundy
bergundy approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear to me where the assertions happen but the code LGTM.

@Sushisource Sushisource merged commit f31f927 into main Feb 23, 2024
@Sushisource Sushisource deleted the encode-update-payloads branch February 23, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Updates not run through data converters
2 participants
@Sushisource @bergundy