Add tests of asyncio.Lock and asyncio.Semaphore usage #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
sdk-2358-workflow-mutex-and-semaphore
branch
from
87fc797 to
390ee94
Compare
dandavison
force-pushed
the
sdk-2358-workflow-mutex-and-semaphore
branch
from
390ee94 to
6eb176a
Compare
dandavison
force-pushed
the
sdk-2358-workflow-mutex-and-semaphore
branch
from
94d0d38 to
2e68dad
Compare
cretz
reviewed
Jul 9, 2024
Comment on lines
425
to
455
| if seen_completion: | ||
| self._warn_if_unfinished_handlers() |
There was a problem hiding this comment.
Yeah, sorry I pushed a temp commit for the cancellation sample I sent you earlier, to force push over later. Force-pushed now.
dandavison
force-pushed
the
sdk-2358-workflow-mutex-and-semaphore
branch
from
2a3a9c3 to
6eb176a
Compare
cretz
approved these changes
Jul 9, 2024
dandavison
force-pushed
the
sdk-2358-workflow-mutex-and-semaphore
branch
2 times, most recently
from
0549ac8 to
a524593
Compare
dandavison
force-pushed
the
sdk-2358-workflow-mutex-and-semaphore
branch
from
a524593 to
72fdcc1
Compare
dandavison
force-pushed
the
sdk-2358-workflow-mutex-and-semaphore
branch
from
72fdcc1 to
1322b5a
Compare
dandavison
force-pushed
the
sdk-2358-workflow-mutex-and-semaphore
branch
from
1322b5a to
f299ffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #554
Add tests confirming that
asyncio.Lockandasyncio.Semaphorecan be used in workflow code to control concurrency of coroutines (tasks spawned by the main coroutine, and update handlers).The fact that these tests pass largely follows from the fact that our event loop implementation has functioning implementations of
call_later()call_soon(), so these tests could alternatively be moved into thefeaturesrepo, as part of a feature test confirming that all languages have mutex/semaphore primitives that can be used for this sort of workflow concurrency control.