Remove experimental warnings from stable APIs #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Feb 13, 2025
|
May need to run |
This reverts commit d6e2aa2.
dandavison
reviewed
Feb 27, 2025
| @@ -501,7 +501,6 @@ async def start_workflow( | |||
| request_eager_start: Potentially reduce the latency to start this workflow by | |||
| encouraging the server to start it on a local worker running with | |||
| this same client. | |||
| This is currently experimental. | |||
There was a problem hiding this comment.
I believe we shouldn't have removed this.
dandavison
reviewed
Feb 27, 2025
| @@ -501,7 +501,6 @@ async def start_workflow( | |||
| request_eager_start: Potentially reduce the latency to start this workflow by | |||
| encouraging the server to start it on a local worker running with | |||
| this same client. | |||
| This is currently experimental. | |||
There was a problem hiding this comment.
I believe we shouldn't have removed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Removed "experimental" tags on things that aren't experimental anymore.
Things stabilized:
Local activities
Eager workflow start
Eager activity execution
Runtime module (top of module says experimental)
Runtime logging and log-forwarding config
Workflow update decorator
Why?
We haven't kept these to date
Checklist
Closes [Feature Request] Remove experimental warning from a few no-longer-experimental APIs #763
How was this tested: