-
Notifications
You must be signed in to change notification settings - Fork 102
Interrupt heartbeating activity on pause #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bef66b5
Init commit - waiting for core changes
THardy98 7fad0b4
add activity paused error usage
THardy98 0539be0
working for async activities
THardy98 c87a948
working for sync activities
THardy98 6db508a
linting and cleanup
THardy98 04c598c
add cancellation details arg to testing ActivityEnvironment cancel
THardy98 6f5104b
remove .vscode
THardy98 ea5b055
formatting
THardy98 fcb7b33
use object reference instead of function, picklable
THardy98 7c0556c
nits
THardy98 5d3339b
use holder
THardy98 330dd41
docstrings
THardy98 21c4e6e
add test for pause/unpause
THardy98 8ffff73
linting, reduce heartbeat timeouts for faster test
THardy98 8cd18d5
make cancellation details non-optional for testing activity env
THardy98 824517c
address pr suggestion
THardy98 4fa5bfa
rebase conflict fixes
THardy98 a48f77a
include is_worker_shutdown as reason for requested cancellation, test…
THardy98 998540a
skip if time-skipping server (does not support pause/unpause yet)
THardy98 56913c4
remove sleep calls from tests, add cancellation details to async canc…
THardy98 bb1b057
replace racy heartbeat check with heartbeat details check
THardy98 983b658
Merge branch 'main' into support_activity_pause
THardy98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be frozen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We mutate the fields in this object to reflect changes across running activity & _context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to frozen class + holder