Skip to content

Versioning Override support #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 16, 2025
Merged

Versioning Override support #871

merged 8 commits into from
May 16, 2025

Conversation

Sushisource
Copy link
Member

What was changed

Add versioning override support to start workflow calls

Why?

Parity

Checklist

  1. Closes

  2. How was this tested:
    Added test

  3. Any docs updates needed?

@Sushisource Sushisource requested a review from a team as a code owner May 15, 2025 23:55
@Sushisource Sushisource force-pushed the versioning-override branch from 04f474e to 3eec5c5 Compare May 15, 2025 23:58
@@ -1037,6 +1039,17 @@ class VersioningBehavior(IntEnum):
queue) when the next task is dispatched."""


class PinnedOverrideBehavior(IntEnum):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider calling this PinnedVersioningOverrideBehavior since it's related to versioning but in the common area

@@ -1037,6 +1039,17 @@ class VersioningBehavior(IntEnum):
queue) when the next task is dispatched."""


class PinnedOverrideBehavior(IntEnum):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of the single-value enum here? Can we just leave this code off until there is a second value that can ever be set?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More are definitely coming, but sure can leave it off for now

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, but nothing blocking

)


class VersioningOverride(ABC):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this may be set on child workflow or activity invocations one day and is why it is in common?

Copy link
Member Author

@Sushisource Sushisource May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes (or available on context info)

)


class AutoUpgradeVersioningOverride(VersioningOverride):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still probably worth a frozen dataclass here so you get the other goodies (hash, str, etc)

@Sushisource Sushisource enabled auto-merge (squash) May 16, 2025 23:05
@Sushisource Sushisource disabled auto-merge May 16, 2025 23:05
@Sushisource Sushisource enabled auto-merge (squash) May 16, 2025 23:07
@Sushisource Sushisource merged commit b53be98 into main May 16, 2025
18 checks passed
@Sushisource Sushisource deleted the versioning-override branch May 16, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants