feat: Optional for public route_table_association #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: option to create public route associate
gn-jayden-z
changed the title
feat: update doc
|
Hi @antonbabenko could you please to review this PR ? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current module does not provide an option to disable the creation of public route associations. This PR hopes to include a variable to control that.
Motivation and Context
We create a network firewall outside of this module and associate the existing public subnet with the new firewall routing tables.
However, this introduces drift since we can't disable the association from this module.
We need to set this as optional for the public route association.
Breaking Changes
None as far as I can observe
var. create_public_route_association is default to true
How Has This Been Tested?
We tested this internally.