Protect jsoncpp against multiple find_package() calls #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trajopt/CMakeLists.txt
Outdated
| find_package(ros_industrial_cmake_boilerplate REQUIRED) | ||
| find_package(osqp REQUIRED) |
There was a problem hiding this comment.
Should this be added?
There was a problem hiding this comment.
Sorry that was from something else and I didn't remove it.
Levi-Armstrong
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in newer
jsoncppversions that raises an error iffind_package(jsoncpp)is called more than once. This PR fences the calls to check if the offending target already exists.See open-source-parsers/jsoncpp#1356