ngclient: Increase default max_root_rotations #2675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this configuration variable controls how many root versions the client will upgrade in a single refresh(). The idea is to prevent a malicious repository from filling the disk with root versions. We want a number that is high enough that a repository should not have made that many roots in the time that clients take to update the "embedded" root that the client shipped with ship with. 32 is small enough that a repository could reach it while clients with v1 embedded in them are still in use. Let's bump to 256: this should be plenty. Signed-off-by: Jussi Kukkonen <[email protected]>
lukpueh
approved these changes
Jul 17, 2024
Pull Request Test Coverage Report for Build 9971250791Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this configuration variable controls how many root versions the client will upgrade in a single refresh(). The idea is to prevent a malicious repository from filling the disk with root versions.
We want a number that is high enough that a repository should not have made that many roots in the time that clients take to update the "embedded" root that the client shipped with.
32 is small enough that a repository could possibly reach it while clients with v1 embedded in them are still in use. Let's bump to 256: this should be plenty.
Fixes #2672