New API dynamic contracts #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrishang
reviewed
Sep 5, 2023
| @@ -8,7 +8,8 @@ import "../../external-deps/openzeppelin/utils/cryptography/EIP712.sol"; | |||
| import "../../external-deps/openzeppelin/utils/structs/EnumerableSet.sol"; | |||
|
|
|||
| library AccountPermissionsStorage { | |||
| bytes32 public constant ACCOUNT_PERMISSIONS_STORAGE_POSITION = keccak256("account.permissions.storage"); | |||
| bytes32 public constant ACCOUNT_PERMISSIONS_STORAGE_POSITION = | |||
There was a problem hiding this comment.
Can we add the following comment wherever we define a storage slot:
/// @custom:storage-location erc7201:extension.manager.storage
nkrishang
reviewed
Sep 5, 2023
| return metadata; | ||
| } | ||
| } | ||
| // // Interface |
There was a problem hiding this comment.
Let's delete ExtensionRegistry and TWRouter related code. If we need it back, we can refer historical commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.