feat: freeze NFT Metadata #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update NFTMetadata extension, add extension to prebuilt TokenERC721. update LoyaltyCard to fit updated extension. add test file for NFTMetadata (no test written yet)
- add testing coverage for NFTMetadata extension - Move URIFrozen to NFTMetadata extension - update INFTMetadata interface
based on feedback: - replace freezeTokenURI with freezeMetadata - make metadata freeze apply to all tokens - add METADATA_ROLE to TokenERC721 - adjust TokenERC721 implementation such that METADATA_ROLE is required to set and freeze metadata.
nkrishang
suggested changes
Sep 26, 2023
nkrishang
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the existing NFTMetadata extension to allow for the freezing of individual token URIs.
In addition to the updated NFTMetadata extension, the extension was added to the prebuilt contract TokenERC721.
The internal function _canFreezeMetadata and _canSetMetadata are virtual to remain unopinionated, but the implementation in TokenERC721 allows the DEFAULT_ADMIN_ROLE to update the metadata and the owner of the individual token to freeze the metadata.
Additional minor updates to LoyaltyCard.sol were made to fit the changes to NFTMetadata extension.
The NFTMetadata extension has full test coverage.