Skip to content

Updatable/Freezable Metadata: BatchMintMetada Extension #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 3, 2023

Conversation

WhiteOakKong
Copy link
Contributor

@WhiteOakKong WhiteOakKong commented Sep 28, 2023

Adding functionality to the batch mint metadata extension to facilitate updates to/freezing of metadata.

Incorporated this implementation into applicable prebuilt contracts: DropERC721 and DropERC1155.

@WhiteOakKong WhiteOakKong marked this pull request as ready for review October 3, 2023 19:28
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Files Coverage Δ
contracts/extension/BatchMintMetadata.sol 97.29% <92.85%> (-2.71%) ⬇️
contracts/prebuilts/drop/DropERC1155.sol 48.61% <50.00%> (+3.29%) ⬆️
contracts/prebuilts/drop/DropERC721.sol 60.49% <54.54%> (+2.74%) ⬆️
...tracts/extension/upgradeable/BatchMintMetadata.sol 77.50% <57.14%> (-10.97%) ⬇️

📢 Thoughts on this report? Let us know!.

@nkrishang nkrishang merged commit 2337863 into thirdweb-dev:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants