Skip to content

Burn to claim macro audit fixes #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Oct 4, 2023
Merged

Burn to claim macro audit fixes #523

merged 27 commits into from
Oct 4, 2023

Conversation

nkrishang
Copy link
Contributor

No description provided.

kumaryash90 and others added 27 commits September 5, 2023 03:27
@kumaryash90
re-write marketplacev3 in new dynamic pattern
9c0d7f4
@kumaryash90
update tests: direct listings
6a7f5d5
@kumaryash90
update tests: english auctions
b93405a
@kumaryash90
update tests: offers
d146105
@kumaryash90
Merge branch 'main' into yash/marketplacev3-dynamic-new
59b2512
@kumaryash90
update function for access control
0cf19ef
@kumaryash90
update storage position acc erc7201
7b6eb70
@nkrishang
Merge branch 'main' into marketplace-v3-audit-macro-1
bf87774
@nkrishang
Use latest dynamic contracts
0d2343d
@nkrishang
Update dynamic-contracts deps
46e6907
@nkrishang
Fix [Q-1] Misleading function name for setMaxTotalSupply
f333a5d
@nkrishang
Fix [Q-2] Missing sanity check when setting BurnToClaimInfo
5fd8a49
@nkrishang
Fix [Q-3] OPERATOR_ROLE is not used
e494bf9
@nkrishang
Fix [Q-5] Named returns are not assigned
1b45787
@nkrishang
Complete fix for [Q-1]
48297f6
@nkrishang
Fix [Q-6] Avoid code duplication by using maxTotalSupply()
1e532c0
@nkrishang
Fix [Q-12] Comply with ERC7201 standard
c38d61c
@nkrishang
Fix [L-2] Missing sanity checks for PrimarySale and PlatformFee recip…
97949b8 
…ients
@nkrishang
Fix [Q-9] Document behavior of tokenURI
17b37be
@nkrishang
Fix [Q-7] Adhere to naming convention for internal function
a998187
@nkrishang
Fix [Q-4] Missing natspec documentation
37d2689
@nkrishang
Addendum [Q-2]: Consider removing redundant check in verifyBurnToClaim
721fcc9
@nkrishang
Addendum [Q-1]: use totalMinted instead of currentIndex in _checkTota…
a63939c 
…lSupply
@nkrishang
Addendum [L-2]: appendix B
e994c83
@nkrishang
Addendum [Q-12]: fully comply with ERC7201
72edf45
@nkrishang
merge main -> this
2d38df5
@nkrishang
Fix test
c45350d
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @thirdweb-dev/[email protected]

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...racts/extension/upgradeable/AccountPermissions.sol 40.90% <ø> (ø)
...tracts/extension/upgradeable/BatchMintMetadata.sol 77.50% <ø> (ø)
contracts/extension/upgradeable/BurnToClaim.sol 90.47% <100.00%> (+0.47%) ⬆️
...ntracts/extension/upgradeable/ContractMetadata.sol 90.00% <ø> (+20.00%) ⬆️
contracts/extension/upgradeable/DelayedReveal.sol 84.21% <ø> (ø)
contracts/extension/upgradeable/Drop.sol 87.87% <ø> (ø)
contracts/extension/upgradeable/ERC2771Context.sol 0.00% <ø> (ø)
...xtension/upgradeable/ERC2771ContextUpgradeable.sol 53.84% <ø> (+23.07%) ⬆️
contracts/extension/upgradeable/Initializable.sol 11.11% <ø> (ø)
contracts/extension/upgradeable/LazyMint.sol 83.33% <ø> (ø)
... and 24 more

... and 17 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@nkrishang nkrishang merged commit 168b4b1 into main Oct 4, 2023
@nkrishang nkrishang deleted the burn-to-claim-macro-audit-fixes branch October 4, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkrishang @kumaryash90