Skip to content

Marketplace v3 audit macro fixes #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Oct 4, 2023
Merged

Marketplace v3 audit macro fixes #524

merged 24 commits into from
Oct 4, 2023

Conversation

nkrishang
Copy link
Contributor

No description provided.

kumaryash90 and others added 24 commits September 5, 2023 03:27
@kumaryash90
re-write marketplacev3 in new dynamic pattern
9c0d7f4
@kumaryash90
update tests: direct listings
6a7f5d5
@kumaryash90
update tests: english auctions
b93405a
@kumaryash90
update tests: offers
d146105
@kumaryash90
Merge branch 'main' into yash/marketplacev3-dynamic-new
59b2512
@kumaryash90
update function for access control
0cf19ef
@kumaryash90
update storage position acc erc7201
7b6eb70
@nkrishang
Merge branch 'main' into marketplace-v3-audit-macro-1
bf87774
@nkrishang
Use latest dynamic contracts
0d2343d
@nkrishang
Update dynamic-contracts deps
46e6907
@nkrishang
POC test for M-1
88ddc9e
@nkrishang
Fix [M-1] Native tokens can get locked when bidding or buying from th…
0422600 
…e marketplace
@nkrishang
Fix [L-1] Everyone can send native tokens directly to the marketplace
c256b77
@nkrishang
Fix [L-3] Cannot remove upgradability without revoking all default ad…
6ab04e3 
…mins
@nkrishang
Fix [Q-8] Incorrect VERSION used
1a9fffc
@nkrishang
Fix [Q-10] Use ERC721Holder and ERC1155Holder
c57c3c4
@nkrishang
Fix [Q-11] Avoid code duplication by using _msgSender and _msgData
edc8487
@nkrishang
Fix (code comments) [Q-12] Comply with ERC7201 standard
517621c
@nkrishang
Fix [G-1] Reorder struct members to save storage slots
ec6980b
@nkrishang
Fix [L-2] Missing sanity checks for PrimarySale and PlatformFee recip…
8008a96 
…ients
@nkrishang
Fix [Q-7] Adhere to naming convention for internal function
86abf36
@nkrishang
Fix comment
f6d01be
@nkrishang
Addendum [L-1]: test that only weth can send native token to marketplace
fd1be98
@nkrishang
merge main -> this
c6c8e2e
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...arketplace/direct-listings/DirectListingsLogic.sol 88.72% <100.00%> (+0.08%) ⬆️
...ketplace/english-auctions/EnglishAuctionsLogic.sol 98.59% <100.00%> (+<0.01%) ⬆️
...prebuilts/marketplace/entrypoint/MarketplaceV3.sol 18.51% <25.00%> (-6.49%) ⬇️

📢 Thoughts on this report? Let us know!.

@nkrishang nkrishang merged commit 964ac86 into main Oct 4, 2023
@nkrishang nkrishang deleted the marketplace-v3-audit-macro-fixes branch October 4, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkrishang @kumaryash90