Skip to content

[Pay] Allow passing purchaseData with quotes #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Dec 4, 2024

GET -> POST on quotes


PR-Codex overview

This PR primarily focuses on enhancing the Thirdweb payment types by adding a new property PurchaseData to several classes, which allows for additional data to be included in purchase transactions. It also improves the request handling in the GetBuyWithFiatQuote and GetBuyWithCryptoQuote methods.

Detailed summary

  • Added PurchaseData property to:
    • Types.GetBuyWithCryptoStatus
    • Types.GetBuyWithFiatStatus
    • Types.GetBuyWithCryptoQuoteParams
    • Types.GetBuyWithFiatQuoteParams
  • Updated GetBuyWithFiatQuote and GetBuyWithCryptoQuote methods to use POST requests instead of GET.
  • Enhanced error handling to use response status code instead of getResponse.
  • Reformatted conditionals in IsZkSync for better readability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper merged commit b75f909 into main Dec 4, 2024
1 check failed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/purchase-data branch December 4, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant