ERC-6492 Predeploy Signature Verification #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables smart accounts to sign messages and auth as themselves without requiring deployment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage ? 78.20%
=======================================
Files ? 28
Lines ? 4488
Branches ? 619
=======================================
Hits ? 3510
Misses ? 812
Partials ? 166 ☔ View full report in Codecov by Sentry. |
| { | ||
| result = await multicall3 | ||
| .Read<List<Multicall3_Result>>( | ||
| method: "aggregate3", |
There was a problem hiding this comment.
How come you're calling multicall3 here? Was expecting to see a encoded call with the universal validator abi
I guess that works too but then you have a dependency on multicall3 being deployed.
Seems cleaner to do the deploy+ isvalidsig call in solidity which is what the universal validator does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables smart accounts to sign messages and auth as themselves without requiring deployment.
PR-Codex overview
This PR focuses on enhancing the
Thirdwebwallet functionality by implementing ERC-6492 signature verification, adding new classes for multicall operations, and improving contract interaction methods, including support for encoding function calls.Detailed summary
Thirdweb.SmartWallet.Tests.cs.Multicall3_Call3,Multicall3_Result, andErc6492Signatureclasses inAATypes.cs.SupportsInterfacemethod inThirdwebExtensions.cs.CreateCallDatamethod inThirdwebExtensions.cs.ThirdwebRPC.csto include_rpcUrl.EncodeFunctionCallmethod inThirdwebContract.cs.IsValidSignaturemethod inSmartWallet.csfor ERC-6492 verification.SerializeErc6492Signaturemethod inUtils.cs.Constants.cs.